Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Assignment #90

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Assignment #90

wants to merge 2 commits into from

Conversation

tavisca-ssharma
Copy link

codeSonic
codeSonic reviewed Jun 28, 2019
View reviewed changes
Tavisca.Bootcamp.LanguageBasics.Exercise2/Assignment2.cs Outdated

for(int i = 0; i<exactPostTime.Length; i++)
{
string[] hour_min_sec = exactPostTime[i].Split(":");
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

do not use snake casing, use camel casing for local variable names

Tavisca.Bootcamp.LanguageBasics.Exercise2/Assignment2.cs Outdated
Array.Sort(currentTime);
return currentTime[(exactPostTime.Length-1)];

throw new NotImplementedException();
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

remove this, it was only to indicate that code should be written here

codeSonic
codeSonic reviewed Jun 28, 2019
View reviewed changes
Tavisca.Bootcamp.LanguageBasics.Exercise2/Assignment2.cs Outdated
{
string minutes = showPostTime[i].Split(" ")[0];
TimeSpan tspan = new TimeSpan(0, Int32.Parse(minutes), 0);
currentTime[i] = dateTime.Add(tspan).ToString().Split(" ")[1];
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

directly using ToString("HH:mm:ss") will save you further split

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@codeSonic codeSonic codeSonic left review comments

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@tavisca-ssharma @codeSonic