-
Notifications
You must be signed in to change notification settings - Fork 259
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Unexpectedly bad results for billiards.py variant #14
Comments
The billiards example is not implemented with the time-of-impact fix (see our paper) so I'm not surprised that it's making inverse progress. I'll fix this in a few days. |
Thanks! Looking forward to it.
…On Tue, 11 Feb 2020 at 08:53, Yuanming Hu ***@***.***> wrote:
The billiards example is not implemented with the time-of-impact fix (see
our paper) so I'm not surprised that it's making inverse progress. I'll fix
this in a few days.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#14>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAGY2BATTZ2NLDHYTLTAEMLRCHEFJANCNFSM4KRWZHJA>
.
|
Hi @DomNomNom , I added the TOI fix to billiards.py. Gradient quality is significantly improved. Could you have a try? (PS: please also upgrade taichi to 0.4.6+). Thanks. |
Hi @yuanming-hu I've updated taichi and merged your changes, however I'm still seeing similar symptoms: Here's what I'm running: https://github.com/DomNomNom/difftaichi/blob/5326ebfc1c8bd5bfe56b3ba5b68ad891b158aa20/examples/billiards.py |
Any thoughts on this? |
In billiards.py, I've done some changes to the starting condition of the cue ball and the target position. These changes are available here.
What I observed was that in almost every iteration, the result got worse than before not better.
i.e. Loss seems to be increasing:
The ending stable state is not that surprising (no gradient) but the initial trend is concerning me.
The text was updated successfully, but these errors were encountered: