Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Problem with signing using Ledger account on Ethereum after trying to sign on unsupported network #3681

Open
michalinacienciala opened this issue Nov 24, 2023 · 0 comments
Assignees
Labels
Priority: Low Low Monetary / Growth impact, not time-sensitive. Type: Bug Something isn't working

Comments

@michalinacienciala
Copy link
Contributor

I have a problem with signing using Ledger account on Ethereum after trying to sign on unsupported network (low priority, as it can be fixed by disconnecting dapp from the extension).

My steps:

  1. Uninstall Taho
  2. Go to https://link3.to/, disconnect (if connected before) and do a hard reset with cleaning cache. Close
  3. Install Taho and import a Ledger account
  4. Turn ON the testnets and switch to Arb Sepolia
  5. Set Taho as a default wallet
  6. Go to https://link3.to/ and choose Connect wallet. Approve the connection in wallet.
  7. Choose Send message -> Sign

The wallet does not connect, There are these errors in the wallet logs:

chrome-extension://eajafomhmkipbjmfmhebemolkcicgfmd/background.js:118544:24 

Logs (wallet):
Async thunk failed Error: Unsupported network for Ledger signing
    at LedgerService.signMessage (index.ts:550:13)
    at SigningService.signData (index.ts:311:49)
    at main.ts:982:54
    at index.js:306:13
    at Array.map (<anonymous>)
    at Emittery.emit (index.js:304:23)
    at async signing.ts:86:40
    at async utils.ts:168:9

 ProviderBridgeService.routeContentScriptRPCRequest

This I think is expected, because Arbitrum Sepolia is not on a list of networks supported when signing on Ledger (https://github.com/tahowallet/extension/blob/main/background/constants/networks.ts#L178)

But then when I switch to Ethereum and reload the dapp, I'm still having the same issue. Only disconnecting the dapp from the wallet fixes that. I'm not sure if that's a bug or is it how it's supposed to work.
My steps (picking up after step 7):

  1. Switch to Ethereum
  2. Refresh link3.to
  3. Choose Connect wallet.
  4. Send message -> Sign. After that the same errors as after step 7 are shown.
  5. Disconnect link3.to in the extension
  6. Reload link3.to
  7. Connect wallet.
  8. Send message -> Sign.
  9. Approve the signing in Ledger. This finally results in successful connection.

Tested using Taho 0.51.02922c34, Chrome & Brave

@michalinacienciala michalinacienciala added Type: Bug Something isn't working Priority: Low Low Monetary / Growth impact, not time-sensitive. labels Nov 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Priority: Low Low Monetary / Growth impact, not time-sensitive. Type: Bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants