You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Tellurium recognizes KISA0:0000107 for the boolean argument whether to use adaptive time steps. However, this is a term for an algorithm characteristic rather than an algorithm parameter.
I added an algorithm parameter term KISAO:0000656 for this purpose.
Tellurium should either replace KISAO:0000107 with KISAO:0000656 or recognize KISAO:0000656 as a "synonym" for KISAO:0000107.
Actually, the above line should be deleted because neither should be recognized in conjunction with SED-ML UniformTimeCourse.
KISAO_0000656 could be recognized for variable time courses described with the new SED-ML Analysis class.
jonrkarr
changed the title
Recognize KISAO:0000656 in addition to KISA0:0000107
Delete mapping from KiSAO to variable step size for SED-ML UniformTimeCourse
Aug 23, 2021
OK, since the dictionary in question is just 'terms Tellurium recognizes', I added the new term instead of removing the old one. Eventually when we support the generic Analysis class, we'll want it in the list.
For now, there's just an inherent contradiction in providing a 'variable step size' parameter for a uniform time course; the proper thing to do would be to provide an error. I'll leave this open until that's done.
Another possible middle ground is to raise a DeprecationWarning to discourage its use (e.g., to communicate that this would not be portable across tools) while retaining support.
Tellurium recognizes
KISA0:0000107
for the boolean argument whether to use adaptive time steps. However, this is a term for an algorithm characteristic rather than an algorithm parameter.I added an algorithm parameter term
KISAO:0000656
for this purpose.Tellurium should either replace
KISAO:0000107
withKISAO:0000656
or recognizeKISAO:0000656
as a "synonym" forKISAO:0000107
.Here's the relevant line:
tellurium/tellurium/sedml/tesedml.py
Line 245 in 3e7cfb5
The text was updated successfully, but these errors were encountered: