Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Field does not show correct activation date #306

Open
animaux opened this issue Nov 23, 2017 · 10 comments
Open

Field does not show correct activation date #306

animaux opened this issue Nov 23, 2017 · 10 comments

Comments

@animaux
Copy link

animaux commented Nov 23, 2017

When a user is activated the activation date/time is shown in the field. This does not seem to reflect the actual activation date but is set to whenever the entry its is was last saved.

@nitriques
Copy link
Member

So the activation date display the last modified date ?

@nitriques
Copy link
Member

Seems like it !!

@nitriques
Copy link
Member

The timestamp is updated when the activation field is saved. It looks like a feature, not a bug.

What about changing the label by "Last activated" ?

@animaux
Copy link
Author

animaux commented Nov 24, 2017

Hmm. Does not make sense to me. Why should the activation be renewed every time the entry is saved? That would simply mimic the function of the system saved date.

It makes a lot more sense to me to only store/save the date of the initial activation, especially since there is no way to deactivate a user again if I get it right.

@nitriques
Copy link
Member

Yeah but looking at the code, it is clear to me that it is how it was designed. Now, do we still need this ? We would need to git blame the thing before taking a conscious decision.

@animaux
Copy link
Author

animaux commented Nov 24, 2017

The blame game!

I’ll have a look on monday. Not feeling conscious enough anymore today. Thanks for your insights! Good night :)

@nitriques
Copy link
Member

nite nite !

@animaux
Copy link
Author

animaux commented Dec 19, 2017

@brendo and @cz have worked on the activation field file almost exclusively. Maybe they remember if this was a conscious decision or can tell if it is a bug?

@cz
Copy link
Contributor

cz commented Dec 19, 2017

Looks like the timestamp came along after I worked on this field, so I can't speak to the original intent. If I had to guess, though, it sounds like a bug.

@animaux
Copy link
Author

animaux commented Dec 19, 2017

Thanks for chiming in Craig, I do feel the same.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants