Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[1.x] Wrong exception for empty external image responses #164

Open
michael-e opened this issue Feb 28, 2019 · 0 comments
Open

[1.x] Wrong exception for empty external image responses #164

michael-e opened this issue Feb 28, 2019 · 0 comments

Comments

@michael-e
Copy link
Member

When an external image is requested and the response is empty, the exception will be "Error writing to temporary file ...". It should rather be "Error reading external image ...".

I will send a PR to 1.x.
michael-e added a commit to michael-e/jit_image_manipulation that referenced this issue Feb 28, 2019
@michael-e
Fix behaviour for empty external responses
d19c4df 
The file_put_contents function will return 0 if empty content is written, but this should not trigger a writing exception. Empty content should throw an exception before, when checking the curl response.

Fixes symphonycms#164
@michael-e michael-e mentioned this issue Feb 28, 2019
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@michael-e