Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Stop autofill of access key #27

Open
brendo opened this issue Mar 2, 2016 · 1 comment
Open

Stop autofill of access key #27

brendo opened this issue Mar 2, 2016 · 1 comment

Comments

@brendo
Copy link
Member

brendo commented Mar 2, 2016

While deploying a client site this week, we twice got bitten by Chrome prefilling the access key value on the Preferences page.

It would prefill this data with our Symphony password, and then as we'd save the preferences, the key would be overridden and access to S3 was lost.

This happened twice because we enabled and then disabled maintenance mode!

@nitriques
Copy link
Member

@brendo This has already been discussed symphonycms/symphonycms#2258

The w3c spec has not changed (still only supports on and off). I've also seen people saying that it should be ="false"...

Anyways, I've created a git push hook to catch any password from being committed...

I would still be 100% for it...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants