Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for multiple testnets #1915

Open
cryptoBeliever opened this issue Oct 2, 2022 · 0 comments
Open

Add support for multiple testnets #1915

cryptoBeliever opened this issue Oct 2, 2022 · 0 comments
Labels
enhancement New feature or request

Comments

@cryptoBeliever
Copy link
Contributor

cryptoBeliever commented Oct 2, 2022

Current behavior

Currently, the desktop wallet supports one testnet. Network generation hash is a part of the wallet profile. Generation hash is always taken from the official testnet. A switch to another testnet (with a different generation hash) will cause the error/warning and be asked to create a new profile.

The error/warning looks like that:

image

If the user ignores the warning it will be allowed to use a different network.

Expected behavior

The wallet should allow users to support multiple testnets (with different generation hashes).

Something to consider / problems:

  1. Should the wallet profile save the network generation hash and show a warning when connecting to the node with a different one (but the same network type)? Maybe it should be done like in the mobile wallet that will allow the switch to a node with the same network type but a different generation hash? I think we should allow transparently switch between testnet networks (without error - maybe just some warning/notification).

  2. Should the statistics service support multiple testnets as well? Because the community will probably create networks dynamically and statistics services will be replaced with the node watch maybe a better idea is just to do changes on the wallet side.

We can allow the user to add testnet nodes from different networks and add grouping in the node list by generation hash. Something like this:

Testnet 1 (<generation hash1>)
- node1
- node2
- node3

Testnet 2 (<generation hash2>)
- node4
- node5
- node6

The exact solution is to discuss when the task will be taken. Also, current code analyses may be needed.

@cryptoBeliever cryptoBeliever added the enhancement New feature or request label Oct 2, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant