-
Notifications
You must be signed in to change notification settings - Fork 4.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Lsp layer changes latex keybindings #16390
Comments
I can confirm this behavior. It seems intended but might not be optimal:
Moreover:
and:
All in the I don't have a good solution in mind. The latex layer seems a bit extreme in this in comparison to other layers I am using. |
@rommeswi now that I know about all this latex-backend-related changes, I feel even more annoyed. |
I never used the major mode menu in latex but always used the auctex bindings, so I never noticed. I might have checked out the major mode menu once and found it not useful. I never knew that without lsp there is actually a lot of useful stuff in there. Currently, in the latex major mode What can be done immediately is that lsp is allowed to override all the bindings but not remove the entire bunch. |
@smile13241324 do you think a change as I proposed above would be reasonable? LSP can override bindings but does not remove all the latex bindings? |
Hi guys, sure, lets review this layer. My original intention was freeing the conventional bindings, used by lsp, by moving other features to not used keys. Here I have also avoided loading features which should already be covered by the lsp protocol like formatting or inserting. If I have accidentally removed features with this I am sorry, and would of course be open to reintroduce them on bindings which do not violate our key binding conventions. Prs are welcome. |
Description
Lsp layer changes keybindings in latex mode
Reproduction guide 🪲
.tex
fileThe issue goes away when disabling lsp layer
Observed behaviour: 👀 💔
Some keybindings are not present, such as
SPC m b
Expected behaviour: ❤️ 😄
keybindings should not be modified
System Info 💻
Backtrace 🐾
The text was updated successfully, but these errors were encountered: