Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add withdraw liquidity extrinsic #113

Open
freddyli7 opened this issue Jul 19, 2023 · 3 comments · May be fixed by #112
Open

Add withdraw liquidity extrinsic #113

freddyli7 opened this issue Jul 19, 2023 · 3 comments · May be fixed by #112
Assignees
@freddyli7
Labels
Priority: P2

Comments

@freddyli7
Copy link
Contributor

No description provided.

@freddyli7 freddyli7 self-assigned this Jul 19, 2023
@freddyli7 freddyli7 linked a pull request Jul 19, 2023 that will close this issue
feat: Add withdraw liq extrinsic and benchmark #112
Draft
@itsbobbyzzz168 itsbobbyzzz168 added this to the Cycle 1 milestone Jul 25, 2023
@MakMuftic MakMuftic modified the milestones: Cycle 1, Cycle 3 Oct 9, 2023
@itsbobbyzzz168
Copy link

@freddyli7 can we check if this has been pushed to prod/or general status update? If so, can we close?

@freddyli7
Copy link
Contributor Author

@itsbobbyzzz168 no this is not merged yet, there are two stuffs that block it so far:

  1. Polkadot v1.2.0 upgrade PR not merged yet: according to Phala, v1.2.0 should be pushed to prod first to align with Phala/Khala parachain version
  2. We have merged the multiple liquidity holder accounts impl and this withdraw extrinsic will have to be adjusted for that feature too. I haven't done it yet because I think this is low priority, but I can always turn my head to work on it if it is more urgent.

@itsbobbyzzz168
Copy link

Thanks @freddyli7 understood and will push to cycle 1 cheers

@MakMuftic MakMuftic removed this from the Cycle 1 - New Year New Sygma milestone May 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@freddyli7 freddyli7

Labels
Priority: P2
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat: Add withdraw liq extrinsic and benchmark sygmaprotocol/sygma-substrate-pallets
3 participants
@freddyli7 @MakMuftic @itsbobbyzzz168