Skip to content
This repository has been archived by the owner on Apr 10, 2024. It is now read-only.

Add subtrate support to API #9

Open
2 tasks
freddyli7 opened this issue Oct 17, 2022 · 1 comment
Open
2 tasks

Add subtrate support to API #9

freddyli7 opened this issue Oct 17, 2022 · 1 comment
Assignees
Labels
Substrate Issues related to adding substrate support to fee oracle Type: Feature

Comments

@freddyli7
Copy link
Contributor

freddyli7 commented Oct 17, 2022

Expand fee oracle API to support fee data requests where the destination chain is a substrate-based chain with deployed Sygma pallet.

Implementation details

  • Details of fee data message format can be found in technical documentation (will be available after this PR is merged)
  • API endpoint handler function should be expanded so it takes into consideration the destination domain (network) type when constructing a response
  • Additional query property should be supported (length_fee) when the user requests a generic call fee estimate with the substrate-based destination chain.

Testing details

  • Add unit test

Acceptance Criteria

  • Fee Oracle should return appropriate fee data when requested for the destination chain being substrate-based
@MakMuftic MakMuftic self-assigned this Jan 2, 2023
eedygreen added a commit that referenced this issue Jan 20, 2023
@P1sar
Copy link
Collaborator

P1sar commented Feb 7, 2023

@MakMuftic I have updated the task for Solidity changes
https://app.zenhub.com/workspaces/sygma-protocol-62f126a54b7d5a55203732f0/issues/gh/sygmaprotocol/sygma-solidity/60
There are some details regarding the implementation on the soldidity side.
Generally I put notes from the buttom of this document that we were discussing.
Please also check if that is correlates with what you know.

@MakMuftic MakMuftic changed the title Implement a API to return Substrate fee data Add subtrate support to API Mar 6, 2023
@MakMuftic MakMuftic added Substrate Issues related to adding substrate support to fee oracle and removed Priority: P2 labels Apr 10, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Substrate Issues related to adding substrate support to fee oracle Type: Feature
Projects
None yet
Development

No branches or pull requests

3 participants