Rethink [confirm] component theme configuration

[uncenter]

Please describe the problem you're trying to solve

Rename btn_yes and btn_no to btn_active and btn_inactive, and support toggling between the confirm actions ("yes" and "no") with the Tab key or arrows keys.

btn_labels option also probably shouldn't be at the theme level, as it doesn't have much to do with colors and such. Looks like there is already a [confirm] section in yazi.toml that it can go under.

Checklist

• I have searched the existing issues/discussions
• The latest nightly build doesn't already have this feature

[sxyazi]

support toggling between the confirm actions ("yes" and "no") with the Tab key or arrows keys

If the user wants to cancel the confirmation, i.e. choose No, they first need to use Tab to switch from the default Yes to No, and then press Enter.

This requires two steps. Why not just press n or Esc to cancel, which only requires one step?

What's the point of adding an activation state switch? What problem does it solve?

btn_labels option also probably shouldn't be at the theme level, as it doesn't have much to do with colors and such.

You're right, it should be in yazi.toml not theme.toml, can't remember why I put it in theme.toml :/

[uncenter]

I think the primary point of confusion is that the confirm component seems to be doing two things. It's acting like a y/n prompt, while looking like it has multiple options. For example, if I change the button labels to True and False, I assume I would still need to do y/n, despite that not matching the labels. Especially with the default theme styling which inverts the yes option, it looks like it should be toggleable. Maybe removing the invert would help clarify?

[sxyazi]

For example, if I change the button labels to True and False, I assume I would still need to do y/n, despite that not matching the labels

If you change the button labels to True and False, then you should also change the keys to t and f; it's entirely up to you:

yazi/yazi-config/preset/keymap-default.toml

Lines 304 to 305 in c78f39b

	{ on = "n", run = "close", desc = "Cancel the confirm" },
	{ on = "y", run = "close --submit", desc = "Submit the confirm" },

Especially with the default theme styling which inverts the yes option, it looks like it should be toggleable. Maybe removing the invert would help clarify?

The inversion was added to let the user know what the default behavior is. It's more of a safety measure, not necessarily indicating that it can actually be toggled.

[uncenter]

Gotcha. Maybe make it bold then so it looks less like a button?

[sxyazi]

I thought about it again, and I think it's fine for btn_labels to be included in the theme, because it's used to control the button content, and the content itself is part of the style.

For example, users can remove spaces from the default content to make the button more compact:

yazi/yazi-config/preset/theme-light.toml

Line 126 in c78f39b

btn_labels = [ " [Y]es ", " (N)o " ]

yazi.toml should only be used to control the actual behavior, and shouldn't include any information about colors, titles, positions, etc.

That means the existing [input], [confirm], and [pick] should also be moved to theme.toml, so users can modify all styles in one place without having to jump between multiple files:

yazi/yazi-config/preset/yazi-default.toml

Lines 146 to 210 in c78f39b

	[input]
	cursor_blink = false
	# cd
	cd_title = "Change directory:"
	cd_origin = "top-center"
	cd_offset = [ 0, 2, 50, 3 ]
	# create
	create_title = [ "Create:", "Create (dir):" ]
	create_origin = "top-center"
	create_offset = [ 0, 2, 50, 3 ]
	# rename
	rename_title = "Rename:"
	rename_origin = "hovered"
	rename_offset = [ 0, 1, 50, 3 ]
	# filter
	filter_title = "Filter:"
	filter_origin = "top-center"
	filter_offset = [ 0, 2, 50, 3 ]
	# find
	find_title = [ "Find next:", "Find previous:" ]
	find_origin = "top-center"
	find_offset = [ 0, 2, 50, 3 ]
	# search
	search_title = "Search via {n}:"
	search_origin = "top-center"
	search_offset = [ 0, 2, 50, 3 ]
	# shell
	shell_title = [ "Shell:", "Shell (block):" ]
	shell_origin = "top-center"
	shell_offset = [ 0, 2, 50, 3 ]
	[confirm]
	# trash
	trash_title = "Trash {n} selected file{s}?"
	trash_origin = "center"
	trash_offset = [ 0, 0, 70, 20 ]
	# delete
	delete_title = "Permanently delete {n} selected file{s}?"
	delete_origin = "center"
	delete_offset = [ 0, 0, 70, 20 ]
	# overwrite
	overwrite_title = "Overwrite file?"
	overwrite_content = "Will overwrite the following file:"
	overwrite_origin = "center"
	overwrite_offset = [ 0, 0, 50, 15 ]
	# quit
	quit_title = "Quit?"
	quit_content = "The following task is still running, are you sure you want to quit?"
	quit_origin = "center"
	quit_offset = [ 0, 0, 50, 15 ]
	[pick]
	open_title = "Open with:"
	open_origin = "hovered"
	open_offset = [ 0, 1, 50, 7 ]

The reason they were previously placed in yazi.toml is because back then flavors weren't supported, and users could only use theme.toml.

If they added custom styles for these components in theme.toml, it would cause conflicts during updates (see #351 (comment)), but now, that's no longer an issue.

[sxyazi]

Added to v0.5 todo list since it requires breaking changes