diff --git a/.github/workflows/main.yml b/.github/workflows/main.yml index 69d62a4f..e25864c0 100755 --- a/.github/workflows/main.yml +++ b/.github/workflows/main.yml @@ -7,10 +7,12 @@ jobs: strategy: matrix: env: - - {ROS_DISTRO: foxy, ROS_REPO: testing} - - {ROS_DISTRO: foxy, ROS_REPO: main} - - {ROS_DISTRO: galactic, ROS_REPO: testing} - - {ROS_DISTRO: galactic, ROS_REPO: main} + - {ROS_DISTRO: humble, ROS_REPO: testing} + - {ROS_DISTRO: humble, ROS_REPO: main} + - {ROS_DISTRO: iron, ROS_REPO: testing} + - {ROS_DISTRO: iron, ROS_REPO: main} + - {ROS_DISTRO: rolling, ROS_REPO: testing} + - {ROS_DISTRO: rolling, ROS_REPO: main} runs-on: ubuntu-latest steps: - uses: actions/checkout@v1 diff --git a/mapviz/CMakeLists.txt b/mapviz/CMakeLists.txt index 599fe688..5fc2c146 100644 --- a/mapviz/CMakeLists.txt +++ b/mapviz/CMakeLists.txt @@ -38,14 +38,7 @@ find_package(swri_transform_util REQUIRED) find_package(tf2 REQUIRED) find_package(tf2_ros REQUIRED) -# tf2_geometry_msgs 0.12.1 broke API compatibility, so check which version -# we need to use find_package(tf2_geometry_msgs REQUIRED) -if("${tf2_geometry_msgs_VERSION}" VERSION_GREATER "0.12.0") - set(USE_NEW_TF2_TOMSG 1) -else() - set(USE_NEW_TF2_TOMSG 0) -endif() ### PkgConfig ### find_package(PkgConfig REQUIRED) @@ -128,17 +121,9 @@ target_include_directories(rqt_${PROJECT_NAME} include PRIVATE ${CMAKE_CURRENT_SOURCE_DIR} - ${CMAKE_CURRENT_BINARY_DIR}) -target_compile_definitions(rqt_${PROJECT_NAME} - PRIVATE - USE_NEW_TF2_TOMSG=${USE_NEW_TF2_TOMSG} + ${CMAKE_CURRENT_BINARY_DIR} ) -# Foxy uses TF2 .h files, not .hpp files -if ("$ENV{ROS_DISTRO}" STRLESS_EQUAL "galactic") - target_compile_definitions(rqt_${PROJECT_NAME} PRIVATE "-DUSE_TF2_H_FILES") -endif() - target_link_libraries(rqt_${PROJECT_NAME} OpenGL::GL ${GLUT_LIBRARIES} diff --git a/mapviz/include/mapviz/map_canvas.h b/mapviz/include/mapviz/map_canvas.h index ea7b42b5..faf9c4c6 100644 --- a/mapviz/include/mapviz/map_canvas.h +++ b/mapviz/include/mapviz/map_canvas.h @@ -40,12 +40,8 @@ // ROS libraries #include #include -#include -#ifdef USE_TF2_H_FILES -#include -#else #include -#endif +#include #include diff --git a/mapviz/package.xml b/mapviz/package.xml index c69a8321..15b38b3a 100644 --- a/mapviz/package.xml +++ b/mapviz/package.xml @@ -30,9 +30,7 @@ mapviz_interfaces marti_common_msgs pluginlib - rclcpp - rqt_gui_cpp rqt_gui std_srvs @@ -43,7 +41,6 @@ tf2_ros yaml-cpp - launch_xml libqt5-opengl diff --git a/mapviz/src/map_canvas.cpp b/mapviz/src/map_canvas.cpp index 364eb749..e618bf07 100644 --- a/mapviz/src/map_canvas.cpp +++ b/mapviz/src/map_canvas.cpp @@ -73,18 +73,13 @@ geometry_msgs::msg::PointStamped make_point_stamped(double x, double y, double z /** * Convenience method for converting a tf2::Stamped object into - * the equivalent ROS message. This has to be done differently between ROS Dashing - * and Eloquent, so this wraps it up conveniently. + * the equivalent ROS message. * @param transform The source object * @return That tf as a ROS message */ auto tf2_to_msg(const tf2::Stamped& transform) { -#if USE_NEW_TF2_TOMSG == 1 return tf2::toMsg(transform); -#else - return tf2::toMsg, geometry_msgs::msg::TransformStamped>(transform); -#endif } MapCanvas::MapCanvas(QWidget* parent) :