Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix peerDependencies #411

Open
WolfspiritM opened this issue May 18, 2022 · 4 comments · May be fixed by #413
Open

Fix peerDependencies #411

WolfspiritM opened this issue May 18, 2022 · 4 comments · May be fixed by #413

Comments

@WolfspiritM
Copy link

After updating angular and trying to recreate the package-lock with npm >= 7 I get an error cause of peerDependencies:

npm ERR! ERESOLVE unable to resolve dependency tree
npm ERR!
npm ERR! While resolving: [email protected]
npm ERR! Found: @angular/[email protected]
npm ERR! node_modules/@angular/common
npm ERR!   @angular/common@"13.3.7" from the root project
npm ERR!
npm ERR! Could not resolve dependency:
npm ERR! peer @angular/common@"13.1.1" from [email protected]
npm ERR! node_modules/angular2gridster
npm ERR!   angular2gridster@"^13.0.0" from the root project
npm ERR!
npm ERR! Fix the upstream dependency conflict, or retry
npm ERR! this command with --force, or --legacy-peer-deps
npm ERR! to accept an incorrect (and potentially broken) dependency resolution.

Using --legacy-peer-deps works but in my opinion angular2gridster should not have a fixed dependency to 13.1.1 but ^13.1.1 instead.
@L-X-T
Copy link

L-X-T commented Jun 10, 2022

Yes, please fix this, we also don't want to run with "--legacy-peer-deps".

@ramijebara
Copy link

ramijebara commented Jun 13, 2022 •
edited
Loading

We are seeing this issue as well.
Angular 13.3.X, NPM 8.12.1 and NodeJS LTS 16.15.1.
Using npm ci --force is a workaround until the root cause is resolved.

@schiem schiem linked a pull request Aug 5, 2022 that will close this issue
Open
@softengi
Copy link

softengi commented Oct 6, 2022

Alternatively, can add the following in project's package.json -

"overrides": {
    "angular2gridster": {
      "@angular/common": "^13.1.1",
      "@angular/core": "^13.1.1"
    }
  }

@ramijebara
Copy link

We have a forked copy of this repo now that we have since updated to Angular 14.

https://github.com/HyperviewHQ/angular2gridster if anyone is interested.

There is also an open PR to port over the changes to this repo.

I hope you find it useful.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Unpinned the Angular version at 13.1.1 schiem/angular2gridster
4 participants
@WolfspiritM @softengi @ramijebara @L-X-T