Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix north-pacific-gyre hierarchy #1462

Closed
wants to merge 1 commit into from

Conversation

HepoH3
Copy link

@HepoH3 HepoH3 commented Sep 6, 2024

After c24e262 Nelle's samples files processed as if they were placed directly in 'north-pacific-gyre' (see listing below), while right now they placed in '2012-07-03' subdirectory. Running this commands will produce an error instead of 18 lines of result.

## Nelle's Pipeline: Checking Files
Nelle has run her samples through the assay machines
and created 17 files in the `north-pacific-gyre` directory described earlier.
As a quick check, starting from the `shell-lesson-data` directory, Nelle types:
```bash
$ cd north-pacific-gyre
$ wc -l *.txt
```
The output is 18 lines that look like this:
```output
300 NENE01729A.txt
300 NENE01729B.txt
300 NENE01736A.txt
300 NENE01751A.txt
300 NENE01751B.txt
300 NENE01812A.txt
... ...

If this pull request addresses an open issue on the repository, please add 'Closes #NN' below, where NN is the issue number.

Please briefly summarise the changes made in the pull request, and the reason(s) for making these changes.

If any relevant discussions have taken place elsewhere, please provide links to these.

For more guidance on how to contribute changes to a Carpentries project, please review the Contributing Guide and Code of Conduct.

Please keep in mind that lesson Maintainers are volunteers and it may be some time before they can respond to your contribution. Although not all contributions can be incorporated into the lesson materials, we appreciate your time and effort to improve the curriculum. If you have any questions about the lesson maintenance process or would like to volunteer your time as a contribution reviewer, please contact The Carpentries Team at [email protected].

After c24e262 Nelle's samples files processed as if they were placed
directly in 'north-pacific-gyre', while right now they placed in
'2012-07-03' subdirectory.
Copy link

github-actions bot commented Sep 6, 2024

🆗 Pre-flight checks passed 😃

This pull request has been checked and contains no modified workflow files, spoofing, or invalid commits.

It should be safe to Approve and Run the workflows that need maintainer approval.

@HepoH3
Copy link
Author

HepoH3 commented Sep 6, 2024

I found out that there are two north-pacific-gyre dirs:

  • /shell-lesson-data/north-pacific-gyre
  • /filesystem/Users/nelle/north-pacific-gyre

The first one already contains this files as expected (without 2012-07-03 directory). As I see now, the exercise should be executed using this folder. However, I'm a bit confused: what is the filesystem directory for, then? In order to generate .svg figures? Should it be consistent with the shell-lesson-data directory? If so, this PR still applies.

@bkmgit
Copy link
Contributor

bkmgit commented Sep 7, 2024

Thanks for the pull request. Checking it.

@gcapes
Copy link
Contributor

gcapes commented Sep 9, 2024

There should be a zip file to download, which contains the shell-lesson-data directory. This is what learners should be using to follow the lesson (detailed on the setup page). It looks like there are also some legacy pages left around which could maybe be removed? It doesn't look like the filesystem directory is used for anything(?)

When these lessons moved over to being built with R, it looks like the makefile was deleted but it contained a rule to make the zip file, which was

##
## Shell lesson specific commands
## =================================================

ZIPFILE = data/shell-lesson-data.zip

.PHONY : zip
## zip              : create zip file for learners to download
zip : shell-lesson-data
	zip -r -FS $(ZIPFILE) $<

I've had a quick search through the lesson material and I don't think there's a 2012-07-03 directory mentioned, so I think it's all good how it is?

@HepoH3
Copy link
Author

HepoH3 commented Sep 10, 2024

Okay, I think I should close this PR then😅

@HepoH3 HepoH3 closed this Sep 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants