Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] Issues In style.css and script.js #132

Open
4 tasks done
rimmon1234 opened this issue Oct 6, 2024 · 1 comment
Open
4 tasks done

[BUG] Issues In style.css and script.js #132

rimmon1234 opened this issue Oct 6, 2024 · 1 comment
Assignees
Labels

Comments

@rimmon1234
Copy link

rimmon1234 commented Oct 6, 2024

Description

1)Repeated Background Definition: button has two background definitions, which are redundant. You only need one.

2)Improvment of Media Queries:Adding another breakpoint for larger screens, e.g desktops above 1440px, to handle ultra-wide or high-resolution screens.

3)Animations Optimization: Adding will-change to animating elements (e.g., the rainbow effect) can optimize browser performance when handling complex CSS animations.

4)Inefficient DOM Access: In the scroll event listener, you repeatedly access the DOM for scrollTopButton. It's better to store the DOM element in a variable outside the scroll event, so the DOM is not queried on every scroll action.

5)Toggle Button Issue: The toggleMenu function compares the maxHeight value with "0px", which could sometimes be "0" or other forms depending on the browser and situation.

assign me the task so I can work on these issues

Screenshots

No response

Any additional information?

No response

What browser are you seeing the problem on?

Google Chrome

Checklist

  • I have checked the existing issues.
  • I have read the Code Of Conduct
  • The changes don't break the code
  • Please attach the screenshots and video of the development work once it is done
@rimmon1234
Copy link
Author

i have fixed the issue please checkout @swaraj-das

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants