Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Svelte 5: properly highlight <component.dot.notation /> #2525

Open
dummdidumm opened this issue Sep 27, 2024 · 1 comment
Open

Svelte 5: properly highlight <component.dot.notation /> #2525

dummdidumm opened this issue Sep 27, 2024 · 1 comment
Labels
feature request New feature or request Fixed Fixed in master branch. Pending production release.

Comments

@dummdidumm
Copy link
Member

Description

In Svelte 5 tags with a dot in it are counted as components. They should be highlighted as such from our textmate grammar.

Proposed solution

adjust grammar

Alternatives

No response

Additional Information, eg. Screenshots

No response

@dummdidumm dummdidumm added the feature request New feature or request label Sep 27, 2024
@paoloricciuti
Copy link
Member

Uh this also reminded me: if you rename the symbol the component with dot notation is also left untouched.

{#each components as component}
    <component.default />
{/each}

If I rename component component.default is not renamed, I don't know if fixing the grammar will also fix this

@dummdidumm dummdidumm added the Fixed Fixed in master branch. Pending production release. label Oct 31, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature request New feature or request Fixed Fixed in master branch. Pending production release.
Projects
None yet
Development

No branches or pull requests

2 participants