Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Getting ERR_UNHANDLED_REJECTION when using fromPromise to read non-existent files. #489

Open
adhocmaster opened this issue Jul 27, 2023 · 2 comments

Comments

@adhocmaster
Copy link

Getting ERR_UNHANDLED_REJECTION when using fromPromise to read non-existent files.

`
import { readFile } from 'node:fs/promises';
public read(path: string): ResultAsync<string, Error> {

    const res = ResultAsync.fromPromise(
        readFile(path, 'utf8'),
        (e) => new Error(`cannot read file ${path}`)
    )
    
    return res
}

`

@azimlumos
Copy link

I am also experiencing this issue. I think this should be addressed. Are you able to reproduce @supermacro ?

Schniz added a commit to Schniz/neverthrow that referenced this issue Aug 5, 2024
@Schniz
Copy link
Contributor

Schniz commented Aug 5, 2024

can't reproduce here: https://github.com/Schniz/neverthrow/blob/schniz/test-nonexistent-path-in-fs/tests/fs.test.ts
can you suggest what I can do to reproduce that? I'm running on MacOS, maybe you're using Windows or Linux and it behaves differently?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants