Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(lib/fetch): dynamic import @supabase/node-fetch #1306

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

liyachun01
Copy link

@liyachun01 liyachun01 commented Nov 9, 2024

Dynamic import('@supabase/node-fetch') in lib/fetch to avoid possible Cannot read property 'bind' of undefined error.

Closes #1303

@liyachun01 liyachun01 changed the title chore(lib/fetch): dynamic import @supabase/node-fetch (#1303) chore(lib/fetch): dynamic import @supabase/node-fetch Nov 9, 2024
@liyachun01 liyachun01 force-pushed the chore/dynamic-node-fetch-import branch from 4bf9624 to 3fb82a1 Compare November 9, 2024 14:01
@liyachun01
Copy link
Author

Similar updates are made to @supabase/postgrest-js, see supabase/postgrest-js#576

@liyachun01
Copy link
Author

Hi @soedirgo, please kindly look at this PR, thanks~

@jsprds
Copy link

jsprds commented Dec 10, 2024

In my opinion this is a very good improvement, thanks for the work @liyachun01! This will probably also solve problems when using supabase-js in an Angular project with SSR enabled.

I hope that this PR can be reviewed and merged in the near future. 🤞

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Request to dynamic import @supabase/node-fetch
2 participants