Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

implement missing GraphQL spec validations #485

Open
imor opened this issue Jan 5, 2024 · 0 comments
Open

implement missing GraphQL spec validations #485

imor opened this issue Jan 5, 2024 · 0 comments
Assignees
Labels
GraphQL spec Relates to compliance with GraphQL spec

Comments

@imor
Copy link
Contributor

imor commented Jan 5, 2024

The following validations are not currently performed by pg_graphql:

https://spec.graphql.org/October2021/#sec-Field-Selections
https://spec.graphql.org/October2021/#sec-Leaf-Field-Selections
https://spec.graphql.org/October2021/#sec-Argument-Names
https://spec.graphql.org/October2021/#sec-Argument-Uniqueness
https://spec.graphql.org/October2021/#sec-Fragment-Name-Uniqueness
https://spec.graphql.org/October2021/#sec-Fragments-On-Composite-Types
https://spec.graphql.org/October2021/#sec-Fragments-Must-Be-Used
https://spec.graphql.org/October2021/#sec-Fragment-spread-is-possible
https://spec.graphql.org/October2021/#sec-Input-Object-Field-Uniqueness
https://spec.graphql.org/October2021/#sec-Directives-Are-Defined
https://spec.graphql.org/October2021/#sec-Directives-Are-In-Valid-Locations
https://spec.graphql.org/October2021/#sec-Directives-Are-Unique-Per-Location
https://spec.graphql.org/October2021/#sec-Variable-Uniqueness
https://spec.graphql.org/October2021/#sec-Variables-Are-Input-Types
https://spec.graphql.org/October2021/#sec-All-Variables-Used
https://spec.graphql.org/October2021/#sec-All-Variable-Usages-are-Allowed

None of them are any blockers because the user has always an option to correct their query to avoid the behaviour due to missing validation but we should consider implementing them for better error messages and spec compliance.

@imor imor added triage-required Pending triage from maintainers GraphQL spec Relates to compliance with GraphQL spec labels Jan 5, 2024
@olirice olirice removed the triage-required Pending triage from maintainers label Feb 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
GraphQL spec Relates to compliance with GraphQL spec
Projects
None yet
Development

No branches or pull requests

2 participants