Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Missing Seaside 2nd edition DU-NL #444

Open
merard4 opened this issue Jan 8, 2023 · 2 comments
Open

Missing Seaside 2nd edition DU-NL #444

merard4 opened this issue Jan 8, 2023 · 2 comments

Comments

@merard4
Copy link

merard4 commented Jan 8, 2023

The cards from second edition of seaside are missing in Dutch. (I can provide names and descriptions of the cards if needed).

@sumpfork
Copy link
Owner

sumpfork commented Jan 9, 2023

Yeah, they simply haven't been translated. Feel free to make a PR with the relevant JSON file changes -- I'm afraid that's the only way I have time to accept translations these days.

Given that the setup for this expansion upgrade is done, I think you mostly just need the card and set entries, see https://github.com/sumpfork/dominiontabs/pull/403/files#diff-c5956f14e6c1daf3f9135fbac96051cbfc7642c02cec198fb01a263858432c8b for reference.

@merard4
Copy link
Author

merard4 commented Jan 10, 2023

Thanks for the feedback. I think I found the right JSON file. I translated everything and made a Pull Request. I've never done this before so I hope I didn't make any mistakes :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants