Activity opens to a white screen.

[chimosky]

Activity opens to a white canvas;

Help button has no effect, and this is in the logs;

libpng warning: iCCP: known incorrect sRGB profile
libpng warning: iCCP: known incorrect sRGB profile
libpng warning: iCCP: known incorrect sRGB profile
Traceback (most recent call last):
  File "/home/ibiam/Activities/latin-squares-activity/main.py", line 72, in run
    self.set_screen(game.view)
  File "/home/ibiam/Activities/latin-squares-activity/main.py", line 52, in set_screen
    view(self)
  File "/home/ibiam/Activities/latin-squares-activity/views/game.py", line 40, in view
    next_level()
  File "/home/ibiam/Activities/latin-squares-activity/views/game.py", line 34, in next_level
    level += 1
    ^^^^^
UnboundLocalError: cannot access local variable 'level' where it is not associated with a value
Traceback (most recent call last):
  File "/home/ibiam/Activities/latin-squares-activity/activity.py", line 82, in show_help
    self.game.show_help()
  File "/home/ibiam/Activities/latin-squares-activity/main.py", line 58, in show_help
    self.help_popup.show()
    ^^^^^^^^^^^^^^^^^^^^
AttributeError: 'NoneType' object has no attribute 'show'
Traceback (most recent call last):
  File "/home/ibiam/Activities/latin-squares-activity/activity.py", line 82, in show_help
    self.game.show_help()
  File "/home/ibiam/Activities/latin-squares-activity/main.py", line 58, in show_help
    self.help_popup.show()
    ^^^^^^^^^^^^^^^^^^^^
AttributeError: 'NoneType' object has no attribute 'show'

[marsian83]

I have fixed this bit
But I already had, I had a little disaster
I use VirtualBox for running the VM and SSh into it using VScode server
My Machine had been corrupted and I had not pushed my changes to github, I did not realize that until now, I started the activity and I have lost some progress
Help, Level Counter and Timer are not here
I have fixed the white screen issue and wil be adding back these things soon

[chimosky]

That really sucks, everything good with your device now?

I'll wait for your other changes, it'll be great to have the tiles moved a bit lower so they're not that close
to the toolbar.

[marsian83]

Fixed padding, added timer, added level display and added help

[chimosky]

Tested, help screen overflows.

[marsian83]

I fixed the help overflow, the image now adjusts itself accoridng to screen aspect ratio

[chimosky]

Haven't tested yet, could you also fix the icon to maintain sugar's design?

[marsian83]

Haven't tested yet, could you also fix the icon to maintain sugar's design?

updating icon now, did you get around to testing this?

[chimosky]

Haven't tested yet, could you also fix the icon to maintain sugar's design?

updating icon now, did you get around to testing this?

I did, and opened #3.

[chimosky]

Tested ebf02cd, the screen overflow is fixed but it seems the help button can only be clicked once and the logs show this;

libpng warning: iCCP: known incorrect sRGB profile
libpng warning: iCCP: known incorrect sRGB profile
libpng warning: iCCP: known incorrect sRGB profile
libpng warning: iCCP: known incorrect sRGB profile

[marsian83]

Fixed now

[marsian83]

I changed the icon with inkscape. How does it adapt sugar colors now?

[marsian83]

I managed to adapt sugar colors, the icon looks better now 😃
are there any changes required or can we publish t he activity?

[chimosky]

I'll test your changes, after that we'll publish the activity.

[marsian83]

have you gottern around to testing it?

[marsian83]

@chimosky Did you test it?

[chimosky]

Tested, the activity icon is filled like it should be when it's been opened, but the fill color isn't the user color like it should be.

The help button also only works just once, and refuses to display the help on subsequent clicks, nothing is shown in the logs.

[marsian83]

I have fixed the help screen, changed the icon as well

[chimosky]

PRs exists so we can agree on your changes before they're merged, you seem not to be making good use of them.

When you make a change, as you're not the only one testing and reviewing this, open a PR so I'll test and point out any issues there and then we'll agree before merging.

Pushing changes when they've not been agreed on just makes it a bit more difficult.

I've not tested, but looking at 4480287, you've also changed the icon name, why is that?

[marsian83]

Sorry, will open PRs for changes from now on.

There is no particular reason for the icon name change though

[chimosky]

If there's no reason for the icon change, then we can revert back to what it was.