Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Search for Implode yields many matches that have no relevance #34

Open
quozl opened this issue Aug 18, 2020 · 1 comment
Open

Search for Implode yields many matches that have no relevance #34

quozl opened this issue Aug 18, 2020 · 1 comment
Labels
upstream wontfix This will not be worked on

Comments

@quozl
Copy link
Contributor

quozl commented Aug 18, 2020

A search for "implode" yields results;

  • Implode-20
  • Pointillism-9
  • ViewSlides-14
  • Simulate-2
  • Words-24
  • Help-20
  • Calculate-46
  • Terminal-47
  • Record-201
  • Flip-10
  • Jukebox-26
  • Paint-70
  • Abacus-61
  • Portfolio-52
  • Write-101
  • ImageVIewer-65
  • Sliderule-35
  • Memorize-58
  • SugarCommander-10
  • Physics-35

All but the first result are expected. Why are the other results shown?

@srevinsaju
Copy link
Member

The levenshtein distance across the other activities are probably smaller, and hence they are shown. Search results are classified on the basis of confidence. implode has the highest confidence (smallest levenshtein distance), and hence shown first. The others still match, well I do not know, it's a library specific issue (luacong/minisearch). I will just check the API documentation if I missed something.

I can not depend on the library, and depend on @free-libre-software 's own implementation of the search, however, that search is for developers, not users.

A search for Fraction Bounce yields no results , but a search for FractionBounce shows the FractionBounce activities. A typo in Implode as Implede shows no results, but will show only and only the Implode Activity when the search query is implode.

@srevinsaju srevinsaju added upstream wontfix This will not be worked on labels Sep 4, 2020
@srevinsaju srevinsaju reopened this Jan 14, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
upstream wontfix This will not be worked on
Projects
None yet
Development

No branches or pull requests

2 participants