-
Notifications
You must be signed in to change notification settings - Fork 280
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
flexbox instead of floats #169
Comments
CSS Grid should be given top priority over flexbox. |
The current Genesis HTML structure isn't particularly compatible with doing site layout with CSS Grid. My hope is that as we evolve the markup API, restructuring the default markup output will become a bit easier in child themes, and applying more modern CSS layout techniques will be a more plausible choice. |
have you considered Foundation 6 framework or html5-boilerplate? |
I have also had this problem. Consider foundation and Genesis compatibility.
…On Fri, Jan 25, 2019, 11:42 AM brodie ***@***.*** wrote:
have you considered Foundation 6 framework or html5-boilerplate?
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
<#169 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AgItSU6OFyUspt-SMX4EKLAP1U7inQBAks5vGqBHgaJpZM4Zf-yJ>
.
|
@nathanrice +1 for "modern CSS layout techniques" - but I don't see that happen anytime soon with Genesis |
Please no... One of the nice things about Genesis is that it's extremely lightweight and not opinionated about such things. FWIW, we've long used Bourbon/Neat for child themes and while we liked it, have left it behind. Back to writing what we need from scratch. I am however looking at TailwindCSS, but even that I wouldn't want to see baked into Genesis. There are far too many options, and cleaning up / overriding them is a pain. |
I've been wondering about this. We use CSS Grid (and flexbox) a fair bit. However CSS Grid doesn't add much for modern "full width" or even "content-sidebar" layouts. Where it excels would be home/landing pages... and block build layouts of rows and columns. That seems like content/block territory and child theme territory. Not opposed to CSS Grid/Flexbox in Genesis, just not sure why/how it would benefit. |
It wouldn't. This is definitely a child theme discussion. What we do in Sample usually makes its way into future themes and theme updates. What we can do in Genesis is make the markup structure a bit flatter so child themes can actually use Grid without resorting to markup hacks. |
Sorry. I totally conflated Genesis with Genesis Sample there. |
FYI, CSS Grid and Flexbox are the future of Web layouts! CSS Grid and or Flexbox should be implemented in Genesis framework itself. https://blog.bitsrc.io/13-css-ui-grid-systems-and-libraries-for-2018-5918104cb591 |
I've been using Flexbox instead of floats in child themes for the last 2 years. No issues there. Sample could probably use it to reduce the amount of CSS.
Genesis doesn't contain any CSS. Child themes can already use CSS Grid if they want to, although you might need to remove some of the Genesis markup to make it worthwhile. |
With the release of Tailwind 1.0, the configuration process became much easier: you can extend or overwrite options with a simple module export. Though the framework if extremely useful, the generated utilities CSS can be still too large (~ 250kb without gzip). |
Is there a reason, why the sample theme still uses floats instead of flexbox (e.g. for site-header, content / sidebar, footer-widgets, etc.)? Are there any plans to switch to flexbox in near future?
The text was updated successfully, but these errors were encountered: