Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove 1.8.7 and 1.9.2 support #320

Closed
brandur opened this issue Oct 6, 2015 · 8 comments
Closed

Remove 1.8.7 and 1.9.2 support #320

brandur opened this issue Oct 6, 2015 · 8 comments
Labels

Comments

@brandur
Copy link
Contributor

brandur commented Oct 6, 2015

1.8.7 was officially retired on June 30th, 2013 1 (over two years ago). Heroku helped out with an extended maintenance period to give people a little more breathing room, but even that ended on July 31st, 2014 2 (about 14 months ago).

Using Ruby 1.8.7 is no longer safe, and we probably shouldn't be encouraging its use. Lets consider removing it from our official support and Travis.

/cc @kyleconroy @russelldavis @mmcgrana Any thoughts on this one?

@brandur
Copy link
Contributor Author

brandur commented Oct 6, 2015

(And let's put 1.9.2 on this retirement list while we're at it. Extended support also ended 14 months ago.)

@brandur brandur changed the title Remove 1.8.7 support Remove 1.8.7 and 1.9.2 support Oct 6, 2015
@kyleconroy
Copy link
Contributor

kyleconroy commented Oct 6, 2015

We actually don't know how many people are using Ruby 1.8.7 or 1.9.2. I have a PR that adds that information to the log, but I forgot to merge it :( I'll try to get it out today.

@russelldavis
Copy link
Contributor

Since we talked about #313 being a breaking change and warranting a major version bump, how about doing this along with that? (Pending reasonably low usage numbers.)

@brandur
Copy link
Contributor Author

brandur commented Oct 6, 2015

+1. Thanks for the input guys!

Just as a last follow-up: IMO, we may want to consider being a little proactive on this one even if there is still some usage of these older versions. They're way out maintenance and not getting security patches or anything anymore. It's probably in everyone's best interest for us to help discourage their use.

@kyleconroy
Copy link
Contributor

I'm also okay with removing support for 1.8.7 and 1.9.2 and calling that a major version bump.

@brandur brandur added the future label Oct 6, 2015
@brandur
Copy link
Contributor Author

brandur commented Oct 7, 2015

Alright, will keep these on life support for now.

Closing this issue, but may open it again if these old versions cause more trouble.

@brandur brandur closed this as completed Oct 7, 2015
@brandur
Copy link
Contributor Author

brandur commented Oct 10, 2015

Just wanted to document that I ended up having to add some pretty nasty hacks to the test suite in order to keep the 1.8.7 tests running (see ca8b49e and 77b1972). Can't drop this stuff quickly enough.

@brandur
Copy link
Contributor Author

brandur commented Oct 19, 2015

And here's another hack: b4600aa

It turns out the 1.8.7 tests had been stable mostly by a lucky run that lasted for a few weeks. When I pushed a branch this morning, they randomly broke.

The above hack fixed the problem, but as seen in #333, every time I do this, there's a risk of introducing bugs in other versions. I think this is yet another indicator that the cost of maintaining these versions is too high.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants