Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Accept multiple {firehose,subtreams}-grpc-listen-addr #68

Open
maoueh opened this issue Nov 15, 2024 · 1 comment
Open

Accept multiple {firehose,subtreams}-grpc-listen-addr #68

maoueh opened this issue Nov 15, 2024 · 1 comment

Comments

@maoueh
Copy link
Contributor

maoueh commented Nov 15, 2024

The various Substreams & Firehose "public" endpoint flags that bind gRPC/HTTP server(s) should accept a list of addresses to listen on. That way, it would be possible to listen for both secure and insecure on 2 different ports.

The implementation would be to use StringArray. It should stay backward compatible so that current config that has just one element still works. Here the test cases:

  • --firehose-grpc-listen-addr=localhost:9000
  • --firehose-grpc-listen-addr=localhost:9000*
  • --firehose-grpc-listen-addr=localhost:9000*,localhost:8000
  • --firehose-grpc-listen-addr=localhost:9000* --firehose-grpc-listen-addr=localhost:8000

In the 2 last cases, both 8000 and 9000 ports should be open, both serving their respective service. The 9000 would be TLS insecure using our snake oil certificate, 8000 would be in plain-text.

@maoueh
Copy link
Contributor Author

maoueh commented Nov 28, 2024

@sduchesneau Is this now completed fully?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant