Create ReservedUtxoService #2
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fassadlr
commented
Aug 19, 2020
| ICoin[] spentCoins = context.TransactionBuilder.FindSpentCoins(transaction); | ||
|
|
||
| // Here we reserve the UTXO OutPoint so that it cant be selected again. | ||
| if (spentCoins.Any()) |
There was a problem hiding this comment.
@zeptin not sure if this should be done here. Perhaps closer to where SC transaction is created?
There was a problem hiding this comment.
I guess this is fine for now, although it is a few layers down from the controller itself.
I suppose the principle of least surprise here is that creating multiple transactions in succession should 'just work' - if it relies on the reservation under the hood then that is acceptable.
zeptin
reviewed
Aug 19, 2020
| { | ||
| foreach (var outPoint in outPoints) | ||
| { | ||
| if (!this.reservedCoins.Contains(outPoint)) |
There was a problem hiding this comment.
Technically you only need to do this check to make the log entry accurate, adding regardless is harmless
zeptin
reviewed
Aug 19, 2020
src/Stratis.Bitcoin.Features.SmartContracts/Wallet/SmartContractTransactionService.cs
Outdated
Show resolved
Hide resolved
…ctTransactionService.cs Co-authored-by: zeptin <[email protected]>
zeptin
approved these changes
Aug 20, 2020
…tisFullNode into fix-inputs-with-sc
fassadlr
pushed a commit
that referenced
this pull request
Nov 3, 2020
fassadlr
added a commit
that referenced
this pull request
Nov 18, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposal to fix stratisproject/StratisBitcoinFullNode#4187