Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MINI_EPIC: Wormchain should upgrade from Tendermint to (not necessarily latest)CometBFT #48

Open
1 of 3 tasks
Tracked by #15
jonathanpberger opened this issue Jul 8, 2024 · 5 comments
Open
1 of 3 tasks
Tracked by #15
Assignees

Comments

@jonathanpberger
Copy link

jonathanpberger commented Jul 8, 2024

Tasks

  1. 1 of 2
    joelsmith-2019 pharr117
  2. 6 of 8
    beckettsean pharr117
@jonathanpberger jonathanpberger changed the title TM => CometBFT Wormchain should upgrade from Tendermint to CometBFT Jul 12, 2024
@pharr117
Copy link

There are currently 2 options for migration that are being explored:

  1. Do a manual migration and resolution of changes by replacing the current branches' core library from Tendermint to CometBFT - work captured here https://github.com/strangelove-ventures/wh-cosmos-sdk/tree/pharr117/tendermint-to-cometbft
  2. Bump the patch version of the Wormhole Cosmos SDK from v0.45.9 to v0.45.16, where v0.45.15 was the version that made the migration - work captured here https://github.com/strangelove-ventures/wh-cosmos-sdk/tree/strangelove-wormhole-chain-v0.45.16

Option 1 provides the following benefits:

  1. No need to check subsequent versions for breakages as this just changes the cometbft dependency version
  2. Easy one line change lacking a full audit

Option 2 provides the following benefits:

  1. Bumps the v0.45 line to latest v0.45 with bug fixes and security updates
  2. A more canonical way to migrate to CometBFT as the migration was handled by the core Cosmos SDK team

We are leaning toward (2), but will need to ensure bumping to latest v0.45 does not introduce changes that the Wormhole project wants to avoid, like consensus breaking changes requiring a coordinated upgrade. We will also need to ensure that the change does not impact the Wormhole chain repo too significantly.

@pharr117
Copy link

pharr117 commented Jul 12, 2024

ADR here #54. This ADR goes with option (2) above. This will require extensive analysis for consensus breaking changes/requirements for coordinated upgrade. One of the goals of this migration is to achieve it without a coordinated upgrade, as that would require the team to push off the change to a later date.

@jonathanpberger
Copy link
Author

Done and in a branch; @pharr117 will cut a PR this week and then we'll close the ticket.

@jonathanpberger jonathanpberger changed the title Wormchain should upgrade from Tendermint to CometBFT MINI_EPIC: Wormchain should upgrade from Tendermint to CometBFT Jul 15, 2024
@jonathanpberger jonathanpberger changed the title MINI_EPIC: Wormchain should upgrade from Tendermint to CometBFT MINI_EPIC: Wormchain should upgrade from Tendermint to (not necessarily latest)CometBFT Jul 15, 2024
@jonathanpberger
Copy link
Author

jonathanpberger commented Jul 22, 2024

@pharr117 sez "for these early PRs, we'll just run TILT (and possibly ICT if it's ready"

@jonathanpberger
Copy link
Author

Blocking this story til TILTS VPS situation is sorted (#61 )

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants