cmd/horcrux: showStateCmd should check for errors other than os.IsNotExist

[odeke-em]

This code in here

horcrux/cmd/horcrux/cmd/state.go

Lines 33 to 36 in 0ba5fda

	if _, err := os.Stat(config.HomeDir); os.IsNotExist(err) {
	return fmt.Errorf("%s does not exist, initialize config with horcrux config init and try again", config.HomeDir)
	}

assumes that the only error ever will be os.IsNotExist but there is a huge variety of errors that can be returned especially in tools like this that can be deployed on containers

Suggestion

Check for other errors if not nil and handle them appropriately like this

switch _, err := os.Stat(config.HomeDir); {
case err == nil:
        // Do nothing here.
case os.IsNotExist(err):
 	return fmt.Errorf("%s does not exist, initialize config with horcrux config init and try again", config.HomeDir) 
default:
        return fmt.Errorf("%w unhandled error", err)
 } 

[jonathanpberger]

Currently only checks for non-existent errors, but others could lurk and cause unintelligible results