Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Zenith // Horcrux Compatibility #109

Open
danbryan opened this issue Oct 4, 2022 · 4 comments
Open

Zenith // Horcrux Compatibility #109

danbryan opened this issue Oct 4, 2022 · 4 comments

Comments

@danbryan
Copy link
Contributor

danbryan commented Oct 4, 2022

I noticed that horcrux is not supported by Zenith.
https://meka.tech/zenith#signing

@danbryan will be chatting with them on October 13th and will ask for details about why it's not supported, and if their is anything strangelove can do to help.

@danbryan danbryan self-assigned this Oct 4, 2022
@chillyvee
Copy link
Contributor

chillyvee commented Oct 19, 2022

Since TMKMS is supported, maybe it's not yet tested rather than "does not work"?

@tsenart
Copy link

tsenart commented Oct 27, 2022

Hey all,

We are working on a Tendermint ADR for expansion of the PrivValidator interface. For the time being, tmkms is compatible because we maintain a fork that essentially allows external block building requests to be signed (i.e. authenticated). These requests, unlike Votes and Proposals, don't end up on-chain state and don't risk any slashing of validators, so they don't need double signing prevention.

We found it hard to modify horcrux to support signing of this additional message because the double signing prevention logic is spread across many layers and we didn't have the time to dig deeper at that point. We'd be happy for you to contribute to this effort!

@danbryan
Copy link
Contributor Author

danbryan commented Nov 7, 2022

For meketek signing on horcrux, we need to add support for the additional handlers.

  • add request handlers for SignMekatekBuild and SignMekatekChallenge

meka-dev/tmkms@v0.12.2...v0.12.2-mekatek.2

@danbryan danbryan mentioned this issue Nov 7, 2022
@tsenart
Copy link

tsenart commented Nov 7, 2022

@danbryan: Only SignMekatekBuild is necessary. SignMekatekChallenge is deprecated.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants