Skip to content
This repository has been archived by the owner on Jan 16, 2023. It is now read-only.

Separating header click action from toggle click action #177

Open
LuisPinaSoares opened this issue Apr 3, 2019 · 7 comments
Open

Separating header click action from toggle click action #177

LuisPinaSoares opened this issue Apr 3, 2019 · 7 comments

Comments

@LuisPinaSoares
Copy link

Hi,

We had the need for a feature.
Which is being able to have separated action capabilities for toggle clicking and header clicking (Having only a onToggle blocks that).
For us it seemed a pretty core feature for a thing like a tree.
We have an implementation that adds this feature, does anyone else has this need?

Does it make sense to make a PR?

@metehansenol
Copy link

Hi @LuisPinaSoares I need that feature. Do you think to open a pull request or could you show that how do you implement it?

@dotneet
Copy link

dotneet commented Jul 3, 2019

@LuisPinaSoares
Copy link
Author

Hi @metehansenol , it didn't made sense for me to override a lot of stuff.
In the end, i just created a tree from scratch 100 lines of code or so were enough.

@maximilianoforlenza
Copy link
Collaborator

@dotneet Why don't you send a PR with that feature?

@dotneet
Copy link

dotneet commented Aug 18, 2019

@maximilianoforlenza
Can you accept the following changes? If so I will make a PR.
dotneet@3df4a64

@maximilianoforlenza
Copy link
Collaborator

maximilianoforlenza commented Aug 18, 2019

@dotneet yes, please change the unit tests if these fail

@dotneet
Copy link

dotneet commented Aug 19, 2019

@maximilianoforlenza I've created a PR. Please review it.
#229

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Development

No branches or pull requests

4 participants