Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

既存機能のリファクタリング：名言ドメイン #25

Open
hiarc opened this issue Apr 28, 2021 · 1 comment · May be fixed by #31
Open

既存機能のリファクタリング：名言ドメイン #25

hiarc opened this issue Apr 28, 2021 · 1 comment · May be fixed by #31
Assignees
@hiarc
Labels
refactor リファクタリング

Comments

@hiarc
Copy link
Collaborator

hiarc commented Apr 28, 2021

No description provided.

hiarc added a commit that referenced this issue Apr 28, 2021
@hiarc
distraction: #25 プロトタイプのソースコードを.gitignoreフォルダ配下に移動した
6fc6bd6
stomy13 added a commit that referenced this issue Apr 28, 2021
@stomy13
chore: #25 バイナリファイルはgitに含めない
8a09a01
hiarc added a commit that referenced this issue Apr 28, 2021
@hiarc
refactor: #25 名言と値オブジェクトのドメインをコーディングした
ceddfcc
hiarc added a commit that referenced this issue Apr 28, 2021
@hiarc
refactor: #25 godocを追加した
621d9a5
stomy13 added a commit that referenced this issue Apr 28, 2021
@stomy13
refactor: #25 Witticismのコンストラクタ作成。インスタンスが生成できることの確認のテスト追加。
9368980
stomy13 added a commit that referenced this issue Apr 28, 2021
@stomy13
refactor: #25 WitticismIdをUUIDで生成する
b2ec065
@hiarc hiarc added the refactor リファクタリング label Apr 28, 2021
@hiarc hiarc linked a pull request Apr 28, 2021 that will close this issue
Open
@hiarc hiarc pinned this issue Apr 28, 2021
hiarc added a commit that referenced this issue May 1, 2021
@hiarc
refactor: #25 発案者の値オブジェクトを実装した
3c6bbb8
hiarc added a commit that referenced this issue May 1, 2021
@hiarc
chore: #25 ライブラリの更新によるコメントの削除
53d67e6
hiarc added a commit that referenced this issue May 6, 2021
@hiarc
refactor: #25 名言ドメインのSentence（値オブジェクト）のテストと実装をした
99b5512
hiarc added a commit that referenced this issue May 6, 2021
@hiarc
refactor: #25 名言の永続化処理を実装した
1e85767
hiarc added a commit that referenced this issue May 6, 2021
@hiarc
chore: #25 保存時のオートフォーマットを有効にした
5f5a83f
@hiarc
Copy link
Collaborator Author

hiarc commented May 6, 2021

参考：
埋め込み構造体について

stomy13 added a commit that referenced this issue May 9, 2021
@stomy13
refactor #25 名言リポジトリのインスタンス化時にインターフェースとして返すようにした
4ea511a
hiarc added a commit that referenced this issue May 9, 2021
@hiarc
refactor: #25 ユビキタス言語の変更にともないシーケンス図の文言を変更した
fc285b8
stomy13 added a commit that referenced this issue May 9, 2021
@stomy13
refactor #25 名言追加のユースケース処理を実装した
804e113
stomy13 added a commit that referenced this issue May 9, 2021
@stomy13
refactor #25 名言ファクトリを実装した
4d3ea66
stomy13 added a commit that referenced this issue May 9, 2021
@stomy13
refactor #25 名言追加のユースケース処理の戻り値を正しくした
26ec7c6
stomy13 added a commit that referenced this issue May 9, 2021
@stomy13
refactor #25 名言追加のコントローラーを実装した
1051b6b
stomy13 added a commit that referenced this issue May 9, 2021
@stomy13
chore #25 名言ドメインモデルのテストエラーを解消
85089c3
stomy13 added a commit that referenced this issue May 9, 2021
@stomy13
refactor #25 Github Actionsの導入
a831d03
stomy13 added a commit that referenced this issue May 9, 2021
@stomy13
refactor #25 Github Actionsのテストエラー解消
f478c10
stomy13 added a commit that referenced this issue May 9, 2021
@stomy13
refactor #25 Github Actionsのテストエラー解消
975f398
stomy13 added a commit that referenced this issue May 9, 2021
@stomy13
refactor #25 Github Actionsのテストエラー解消(defaultのworking-directory追加)
6a16c5a
hiarc added a commit that referenced this issue May 9, 2021
@hiarc
chore: #25 SQLファイル名の修正
bc7b3f4
hiarc added a commit that referenced this issue May 12, 2021
@hiarc
chore: #25 CIのDBポートを設定した
774f28b
hiarc added a commit that referenced this issue May 12, 2021
@hiarc
fix: #25 CIの構文を修正した
bea1939
hiarc added a commit that referenced this issue May 12, 2021
@hiarc
fix: #25 CIのDBが起動しないため修正した
3fea571
hiarc added a commit that referenced this issue May 12, 2021
@hiarc
fix: #25 CIのDBが起動しないためポートを指定した
92f894f
hiarc added a commit that referenced this issue May 12, 2021
@hiarc
fix: #25 CIのDB設定を修正した
522de12
hiarc added a commit that referenced this issue May 12, 2021
@hiarc
fix: #25 CIのDB起動コマンドを修正した
589fb93
hiarc added a commit that referenced this issue May 12, 2021
@hiarc
fix: #25 CIのDBが起動しないため構成ファイルを修正した
76b6c6e
hiarc added a commit that referenced this issue May 12, 2021
@hiarc
fix: #25 CIのDBが起動しないため構成ファイルを修正した
c9f28de
hiarc added a commit that referenced this issue May 12, 2021
@hiarc
fix: #25 CIのDBが起動しないため構成ファイルを修正した
d0cd0df
hiarc added a commit that referenced this issue May 12, 2021
@hiarc
fix: #25 CIの構成ファイルを修正
c426b5c
hiarc added a commit that referenced this issue May 12, 2021
@hiarc
chore: #25 開発環境とCI上でMySQLのホスト名を分けるために環境変数を設けた
2bb1e77 
GitHubActionsのテスト実行時にはActionが実行するホストのIPを指定する
hiarc added a commit that referenced this issue May 12, 2021
@hiarc
fix: #25 CI構成文のインデント修正
d447e71
hiarc added a commit that referenced this issue May 12, 2021
@hiarc
fix: #25 gormで扱うDBリレーション名を明示的に指定した
c736af2
hiarc added a commit that referenced this issue May 12, 2021
@hiarc
chore: #25 DBの自動テスト用にCIの構成ファイルを修正
59fa070
stomy13 added a commit that referenced this issue May 12, 2021
@stomy13
chore: #25 READMEにGithubActionsのステータスのバッジを追加した
2e467f3
hiarc added a commit that referenced this issue May 15, 2021
@hiarc
refactor: #25 バリデーションエラーの実装(WIP)
51811d7
stomy13 added a commit that referenced this issue May 23, 2021
@stomy13
refactor: #25 バリデーションエラーの実装
81e5b71
stomy13 added a commit that referenced this issue May 23, 2021
@stomy13
refactor: #25 バリデーションエラーで予約語を使わないようにした
9cdba19
hiarc added a commit that referenced this issue May 23, 2021
@hiarc
refactor: #25 JSON解析のエラー処理とテストを実装した
575f7ca
stomy13 added a commit that referenced this issue May 23, 2021
@stomy13
refactor: #25 DBのエラー処理とテストを実装した
2b83215
hiarc added a commit that referenced this issue May 23, 2021
@hiarc
refactor #25 エラー構造体の型を判定してHTTPレスポンスを返す
5e2a8ca
hiarc added a commit that referenced this issue May 29, 2021
@hiarc
refactor: #25 interactorのユニットテストを実装した
51decc5
hiarc added a commit that referenced this issue May 29, 2021
@hiarc
refactor: #25 ユニットテストのアサートを追加した
e76a2bf
hiarc added a commit that referenced this issue May 29, 2021
@hiarc
refactor: #25 mottingサーバーの起動処理を追加した
68a9bf7
hiarc added a commit that referenced this issue Jun 5, 2021
@hiarc
refactor: #25 mottingで使うコンポーネントに依存性を注入した
fc7fa2f
hiarc added a commit that referenced this issue Jun 5, 2021
@hiarc
refactor: #25 名言を追加するための処理とサーバーのURLをマッピングした
86aa3df
hiarc added a commit that referenced this issue Jun 12, 2021
@hiarc
refactor: #25 名言の作成処理がユースケース層に書かれていたため、ドメイン層に移動した
c453124
hiarc added a commit that referenced this issue Jun 12, 2021
@hiarc
refactor: #25 ユーザーが追加した名言を取得する処理を実装した
86b0bdd
@stomy13 stomy13 removed their assignment Feb 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@hiarc hiarc

Labels
refactor リファクタリング
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Refactor/25 既存機能のリファクタリング：名言ドメイン stomy13/motting
2 participants
@hiarc @stomy13