Add watcher for the secret used in the discovery config #504
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Cameron Wall <[email protected]>
Signed-off-by: Cameron Wall <[email protected]>
Signed-off-by: Cameron Wall <[email protected]>
Signed-off-by: Cameron Wall <[email protected]>
cameronmwall
changed the title
ngraham20
requested changes
Nov 15, 2024
Signed-off-by: Cameron Wall <[email protected]>
|
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: cameronmwall, ngraham20 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
We now watch for any changes made to the secret referenced in the discovery config and re-reconcile the discovery config controller
Related Issue
https://issues.redhat.com/browse/ACM-15113
Changes Made
Added to go routine which watches all secrets on the cluster. However the re-reconcile is only triggered if the updated secret matches the name and namespace of that referenced in the discovery config