Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed renovate.json file name #465

Merged
merged 1 commit into from
Oct 15, 2024

Conversation

dislbenn
Copy link
Contributor

Description

When adding the renovate.json file to the repo, the filename was incorrectly spelled which led to the konflux jobs not working as intended. This PR will correct the filename in order for the konflux jobs to properly run on the desired schedule.

Related Issue

If applicable, please reference the issue(s) that this pull request addresses.

Changes Made

Updated .github/renovat.json to .github/renovate.json

Screenshots (if applicable)

Add screenshots or GIFs that demonstrate the changes visually, if relevant.

Checklist

  • I have tested the changes locally and they are functioning as expected.
  • I have updated the documentation (if necessary) to reflect the changes.
  • I have added/updated relevant unit tests (if applicable).
  • I have ensured that my code follows the project's coding standards.
  • I have checked for any potential security issues and addressed them.
  • I have added necessary comments to the code, especially in complex or unclear sections.
  • I have rebased my branch on top of the latest main/master branch.

Additional Notes

Add any additional notes, context, or information that might be helpful for reviewers.

Reviewers

Tag the appropriate reviewers who should review this pull request. To add reviewers, please add the following line: /cc @reviewer1 @reviewer2

Definition of Done

  • Code is reviewed.
  • Code is tested.
  • Documentation is updated.
  • All checks and tests pass.
  • Approved by at least one reviewer.
  • Merged into the main/master branch.

@openshift-ci openshift-ci bot requested review from gparvin and ngraham20 October 15, 2024 13:55
@openshift-ci openshift-ci bot added the approved PR approval has been given label Oct 15, 2024
@dislbenn
Copy link
Contributor Author

/cherry-pick backplane-2.7

@openshift-cherrypick-robot

@dislbenn: once the present PR merges, I will cherry-pick it on top of backplane-2.7 in a new PR and assign it to you.

In response to this:

/cherry-pick backplane-2.7

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Copy link

sonarcloud bot commented Oct 15, 2024

Copy link

openshift-ci bot commented Oct 15, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dislbenn, gparvin

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-bot openshift-merge-bot bot merged commit afb7555 into stolostron:main Oct 15, 2024
8 checks passed
@openshift-cherrypick-robot

@dislbenn: new pull request created: #467

In response to this:

/cherry-pick backplane-2.7

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved PR approval has been given dco-signoff: yes lgtm
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants