Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Is this still being maintained? #265

Open
ikisler opened this issue Oct 4, 2022 · 8 comments
Open

Is this still being maintained? #265

ikisler opened this issue Oct 4, 2022 · 8 comments

Comments

@ikisler
Copy link

ikisler commented Oct 4, 2022

Hey there, is this library is still being maintained? The last release was ~3 years ago, and there are open security advisories (see #257).

Would there be any interest in bringing on another maintainer?

Alternatively, does anyone own a fork where they are maintaining security patches? I looked through the existing forks on GH but didn't see any that looked up to date.

Thank you!

@jfmengels
Copy link
Collaborator

Hi @ikisler

This tool is not being actively maintained no. I would highly recommend using elm-review which is actively maintained and a more powerful tool than elm-analyse.

@ikisler
Copy link
Author

ikisler commented Oct 5, 2022

Thanks for the quick response @jfmengels! I will check out elm-review as a replacement.

@cyberglot
Copy link

Maybe put an archive badge on it? 😬

@jfmengels
Copy link
Collaborator

@stil4m Would you be fine with me officially deprecating the tool?

@stil4m
Copy link
Owner

stil4m commented Nov 8, 2022 via email

@AntouanK
Copy link

@jfmengels If I'm honest, I don't see why it should be "deprecated".
This tool still does what it says it does.
elm-review can do the same, for sure, but needs lots configuration for it.
I tried to replicate some of the elm-analyse features but I need to spend time to learn and write rules.
elm-analyse does what it does out-of-the-box.

I understand the dependencies might be an issue. Either because of the installation step, or because of security issues. @ikisler

@stil4m I forked the repo and updated all the npm dependencies. The tool works fine with just some minor tweaks.

I also removed all the INFO logging ( it was too noisy for me ) and put it behind a flag.
Plus I made a bundle js file that can run on it's own, to not need any npm install or additional steps.

AntouanK#1

I'll use that from now on, but if you want I can make a PR here so you can update the original elm-analyse

@jfmengels
Copy link
Collaborator

It should be deprecated because the project is not maintained anymore, and because a different solution — with better and more accurate reports and more powerful features — exists.

Pretty much all of Elm Analyse's features exist in elm-review (and all of its rules can be found somewhere).

elm-analyse does what it does out-of-the-box.

Starting with a default configuration (like below) gives you the same thing, and more.

elm-review init --template jfmengels/elm-review-config/application

@maca
Copy link

maca commented Mar 15, 2023

It just works ;)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

6 participants