Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

undefined method `dots_to_slashes' #44

Open
ralphrmartin opened this issue Apr 18, 2019 · 6 comments
Open

undefined method `dots_to_slashes' #44

ralphrmartin opened this issue Apr 18, 2019 · 6 comments

Comments

@ralphrmartin
Copy link
Contributor

Various casks are now causing error messages about use of an undefined method:

brew cask outdated
Warning: Cask 'lockrattler' is unreadable: undefined method `dots_to_slashes' for "2019.04":Cask::DSL::Version
Did you mean?  dots_to_hyphens
Warning: Cask 'archichect' is unreadable: undefined method `dots_to_slashes' for "2019.04":Cask::DSL::Version
Did you mean?  dots_to_hyphens
Warning: Cask 'systhist' is unreadable: undefined method `dots_to_slashes' for "2019.04":Cask::DSL::Version
Did you mean?  dots_to_hyphens
Error: Cask 'systhist' is unreadable: undefined method `dots_to_slashes' for "2019.04":Cask::DSL::Version
Did you mean?  dots_to_hyphens
@ralphrmartin
Copy link
Contributor Author

See Homebrew/homebrew-cask#62082 for suggested way of how to fix these.

@retropipes
Copy link

Now these warnings have changed:

Warning: Calling #dots_to_slashes is deprecated! There is no replacement.
Please report this to the sticklerm3/pourhouse tap:
/usr/local/Homebrew/Library/Taps/sticklerm3/homebrew-pourhouse/Casks/archichect.rb:6

Warning: Calling #dots_to_slashes is deprecated! There is no replacement.
Please report this to the sticklerm3/pourhouse tap:
/usr/local/Homebrew/Library/Taps/sticklerm3/homebrew-pourhouse/Casks/systhist.rb:6

I would think the recommended fix still applies.

@haakonstorm
Copy link

haakonstorm commented Jul 23, 2019

Pardon my ignorance, but what is the recommended fix? Reading Homebrew/homebrew-cask#62082 but I'm getting the following errors

Warning: Calling #dots_to_slashes is deprecated! There is no replacement.
Please report this to the sticklerm3/pourhouse tap:
  /usr/local/Homebrew/Library/Taps/sticklerm3/homebrew-pourhouse/Casks/systhist.rb:6

e.g. when searching for taps:

brew search gitkraken-glo

When you write "suggested way to fix these" are you referencing brew audit and brew style?

After making all changes to the cask:

  brew cask audit --download {{cask_file}} is error-free.
  brew cask style --fix {{cask_file}} reports no offenses.

?

@retropipes
Copy link

Indeed I am referencing brew cask audit and brew cask style as tools to help get these issues corrected. Homebrew provides those commands for tap maintainers as well as core developers, since Homebrew changes sometimes, and all the providers could use help ensuring their taps don't break.

@haakonstorm
Copy link

I'm sorry if I was unclear; I understood cask audit and cask style as tools for maintainers and developers, but for me as a regular user (albeit on macOS 10.15 beta!) as well? Pardon my ignorance; I just started using cask after all this years brewing.

@retropipes
Copy link

Ah, Homebrew likely won't function as intended on macOS 10.15 beta, since it may not have bottles for all formulae or know enough about the development tools to compile everything from source code.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants