Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

148 add training workchain #153

Open
wants to merge 9 commits into
base: main
Choose a base branch
from

Conversation

federicazanca
Copy link
Collaborator

@federicazanca federicazanca commented Jul 31, 2024

Close #148
training workgraph.
it takes as inputs: folder and the inputs of janus (actually just the janusconfigfile) and quantumespresso's workchain.
it creates the input files for the training
it outputs the optimised structures and the trained model.

No tests because it will be better to do it when everything is setup in the cloud since the quantumespresso submission is a bit more complex (it might take long times and also we might want to test the ssh connection)

@federicazanca federicazanca self-assigned this Jul 31, 2024
@federicazanca federicazanca added enhancement New/improved feature or request aiida-mlip labels Jul 31, 2024
@ElliottKasoar ElliottKasoar force-pushed the 148-add-training-workchain branch from 1bfa751 to 1f2389e Compare November 18, 2024 14:45
Copy link

@superstar54 superstar54 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the nice work! I add a few small comments.

aiida_mlip/workflows/training_workgraph.py Outdated Show resolved Hide resolved
aiida_mlip/workflows/training_workgraph.py Outdated Show resolved Hide resolved
Comment on lines +213 to +216
wg.to_html()

wg.max_number_jobs = 10
wg.submit(wait=True)

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same comment as in #147

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New/improved feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

add training workchain
4 participants