-
Notifications
You must be signed in to change notification settings - Fork 29
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
2758 fix compilation tests #2759
base: master
Are you sure you want to change the base?
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #2759 +/- ##
=======================================
Coverage 99.88% 99.88%
=======================================
Files 357 357
Lines 49742 49742
=======================================
Hits 49686 49686
Misses 56 56 ☔ View full report in Codecov by Sentry. |
Ready for review. The link check failure (to https://fortranwiki.org/fortran/show/Intrinsic+procedures) is not caused by this PR, the site seems unavailable atm. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks very much for the quick fix Joerg. All looks good and nice to see how encapsulated the problem was.
However, I've realised that we have lib/extract/{netcdf,standalone}/nemo
and the READMEs in those directories talk about the NEMO API. Would you mind renaming those directories (perhaps s/nemo/no_psykal/ or something) and updating the READMEs too?
I completely missed that PR. By now, Sergi has renamed the directory. I've fixed the references to NEMO in the files that were still there. The only exception are references to |
A few small changes to fix #2758.