Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Parameterize event buffer based on maximum numbers of events for each class #258

Open
jadamcrain opened this issue Dec 17, 2022 · 0 comments
Labels
enhancement New feature or request
Milestone

Comments

@jadamcrain
Copy link
Member

jadamcrain commented Dec 17, 2022

Currently, the event buffer is configured based on the maximum number of events for each type. This was how OpenDNP3 did thing, but I don't think it's he best way:

  1. It's easy to misconfigure and it makes it difficult to add support for new event types without breaking configuration
  2. DNP3 event reporting is really geared around classes, not individual types.
  3. You already have to tracking the number of each class in the event buffers to support the related IIN bits.

Using a reserved # for each class is a better mechanism:

  1. It's simpler and more natural to configure things this way since each individual point is assigned to a class.
  2. It's more efficient: it reduces the likelihood of buffer overflow by allowing various types to share space, e.g. Analog and Counters could share all reserved the class 2 space.
  3. It allows new types to be added without breaking configuration since there will only ever be 3 classes.
@jadamcrain jadamcrain added the enhancement New feature or request label Dec 17, 2022
@jadamcrain jadamcrain added this to the 2.0.0 milestone Dec 17, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant