Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Fix mixed citation in JATS #874

Merged
merged 2 commits into from
Mar 24, 2021
Merged

Conversation

rgieseke
Copy link
Contributor

Closes #873

@nokome
Copy link
Member

nokome commented Mar 24, 2021

Thank you @rgieseke !

I have updated the test snapshots and tests now pass. You will see in the snapshots, that thanks to your change we are now capturing title e.g.

  - type: Article
    id: pone-0091296-Choat1
    authors: []
    title: >-
      Choat JH (2012) Spawning aggregations in reef fishes; ecological and
      evolutionary processes. In: Sadovy de Mitcheson Y, Colin PL, editors. Reef
      Fish Spawning Aggregations: Biology, Research and Management. Heidelberg:
      Springer. pp. 85–116.

However, this obviously still needs improvement - but I will pick up that topic in the related issue.

@nokome nokome merged commit 8dc58e3 into stencila:master Mar 24, 2021
@stencila-ci
Copy link
Collaborator

🎉 This PR is included in version 0.111.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

@rgieseke rgieseke deleted the fix/mixed-citation branch July 30, 2021 10:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

JATS: Plain text citation
3 participants