Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clarify stateful #dockter comment #41

Open
giorgiosironi opened this issue Oct 30, 2018 · 1 comment
Open

Clarify stateful #dockter comment #41

giorgiosironi opened this issue Oct 30, 2018 · 1 comment
Assignees

Comments

@giorgiosironi
Copy link

The README says:

Dockter does this by looking for a special # dockter comment in a Dockerfile. Instead of throwing away layers, it executes all instructions after this comment in the same layer - thus reusing packages that were previously installed.

This explanation was a bit difficult to understand, as I thought it was an alternate implementation of the --squash option. That would create a new single layer in which to execute all images, but a new one for each build. This instead will reuse an existing layer, overwriting the contents.

Some thoughts to polish this feature:

  • # dockter does not convey the meaning of this, a more specific annotation like # dockter: stateful could make it easier to search for documentation about this option
  • clarify in README this is going to overwrite an existing, single layer
  • clarify where this state is kept, in the Docker daemon's state files, I guess
  • clarify rolling back to a previous version of the dependencies will be slower as the trade-off, having to modify the existing, single layer
@nokome nokome self-assigned this Nov 1, 2018
@nokome nokome added this to the 1.0.0 milestone Nov 1, 2018
@nokome
Copy link
Member

nokome commented Nov 1, 2018

@giorgiosironi : thanks for the great suggestions! I've added this issue to the 1.0.0 milestone.

@nokome nokome removed this from the 1.0 milestone Jun 14, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants