Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove unimplemented validator types for Parameter #281

Open
nokome opened this issue Jan 13, 2022 · 0 comments
Open

Remove unimplemented validator types for Parameter #281

nokome opened this issue Jan 13, 2022 · 0 comments
Assignees

Comments

@nokome
Copy link
Member

nokome commented Jan 13, 2022

Currently, the component for Parameter allows the user to select several types of validator:

<select name="validator" class="sc-stencila-parameter-default">
  <option disabled="" class="sc-stencila-parameter-default">Select…</option>
  <option value="ArrayValidator" class="sc-stencila-parameter-default">Array</option>
  <option value="BooleanValidator" class="sc-stencila-parameter-default">Boolean</option>
  <option value="ConstantValidator" class="sc-stencila-parameter-default">Constant</option>
  <option value="EnumValidator" class="sc-stencila-parameter-default">Enum</option>
  <option value="IntegerValidator" class="sc-stencila-parameter-default">Integer</option>
  <option value="NumberValidator" class="sc-stencila-parameter-default">Number</option>
  <option value="StringValidator" class="sc-stencila-parameter-default">String</option>
  <option value="TupleValidator" class="sc-stencila-parameter-default">Tuple</option>
</select>

But many of these are unimplemented (either in the component UI, or in terms of actually setting the value in a kernel). I suggest that we reduce the list to Boolean, Integer, Number, String and Enum (i.e. remove Array, Tuple and Constant).

Enum needs some UI to be able to set the possible options, but that's a separate issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants