You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Currently we check for presence of executeHandler function prop on the CodeChunk component to determine whether the code can be executed or not.
The executeHandler is usually attached on page load, currently by the <stencila-executable-toolbar> or the Web Client in the future.
Doing so after page load can lead to a needless re-render and incurs a performance penalty.
Instead we should explore using alternate indicators in the componentWillLoad lifecycle, and avoid a repaint.
We could use the presence of session provider url, or the stencilaWebClient being present in the global scope.
The text was updated successfully, but these errors were encountered:
Currently we check for presence of
executeHandler
function prop on theCodeChunk
component to determine whether the code can be executed or not.The
executeHandler
is usually attached on page load, currently by the<stencila-executable-toolbar>
or the Web Client in the future.Doing so after page load can lead to a needless re-render and incurs a performance penalty.
Instead we should explore using alternate indicators in the
componentWillLoad
lifecycle, and avoid a repaint.We could use the presence of session provider url, or the
stencilaWebClient
being present in the global scope.The text was updated successfully, but these errors were encountered: