Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

System Test: as a DApp developer, I'm able to bump and restore ledger entries #70

Open
sreuland opened this issue Jul 19, 2023 · 1 comment

Comments

@sreuland
Copy link
Contributor

sreuland commented Jul 19, 2023

What problem does your feature solve?

no coverage for js-soroban-client using BumpFootprintExpirationOp and RestoreFootprintOp operations.

What would you like to see?

new test coverage with steps/scenarios that trigger NODEJS(js-soroban-client) to invoke BumpFootprintExpirationOp and RestoreFootprintOpoperations and verify the expected response and outcomes:

  • for bumping contract entries to newer expiry ledgers
  • for restoring contract entires that were evicted

Identify how expired/evicted contract data entry can be created/initiated on target network under test during the test timeframe for local or remote network usage(testnet, futurenet). Are there networks that it won't be possible?

What is best entry point in javascript for a test to exercise state expirations, test should validate that javascript navigates the expected responses from invoke host fn failing first due to expiry has happened to contract entries, and then ensuing bump/restores done and contract fn invoked succesfully afterwards?

Do we need to create a new contract that is purpose built to enable with testing expiration, i.e. it has state, and can set expiration on it to very small timeframe so test can trigger correct outcomes?

What alternatives are there?

@sreuland sreuland changed the title Add coverage for cli contract bump and restore Add coverage for contract bump and restore Jul 24, 2023
@sreuland sreuland changed the title Add coverage for contract bump and restore Add coverage for network bump and restore opertations Jul 24, 2023
@sreuland sreuland changed the title Add coverage for network bump and restore opertations Add coverage for network bump and restore operations Jul 24, 2023
@sreuland sreuland changed the title Add coverage for network bump and restore operations Add coverage for soroban bump and restore operations Jul 24, 2023
@sreuland sreuland added this to the Soroban Pubnet Release milestone Sep 27, 2023
@sreuland sreuland changed the title Add coverage for soroban bump and restore operations Add coverage for state expiration outcomes Sep 27, 2023
@sreuland sreuland changed the title Add coverage for state expiration outcomes System Test: Add coverage for state expiration outcomes Sep 27, 2023
@sreuland
Copy link
Contributor Author

sreuland commented Oct 3, 2023

note, this only establishes coverage for js, cli coverage of the same functionality is done in https://github.com/stellar/soroban-tools/blob/main/cmd/soroban-rpc/internal/test/cli_test.go

@sreuland sreuland changed the title System Test: Add coverage for state expiration outcomes System Test: as a DApp developer, I'm able to bump and restore ledger entries Oct 3, 2023
@mollykarcher mollykarcher removed this from the Soroban Pubnet Release milestone Feb 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Backlog
Development

No branches or pull requests

2 participants