Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

BucketListIsConsistentWithDatabase is too agressive #4573

Open
SirTyson opened this issue Dec 12, 2024 · 0 comments
Open

BucketListIsConsistentWithDatabase is too agressive #4573

SirTyson opened this issue Dec 12, 2024 · 0 comments
Assignees
@SirTyson
Labels
bug

Comments

@SirTyson
Copy link
Contributor

Currently, BucketListIsConsistentWithDatabase checks the SQL offer table against the BucketList for consistency after every call to assumeState. This is too aggressive, as this check is expensive. We should instead only call this invariant after actually updating the offers table after BucketApply, not on every assumeState call.
@SirTyson SirTyson added the bug label Dec 12, 2024
@SirTyson SirTyson self-assigned this Dec 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@SirTyson SirTyson

Labels
bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@SirTyson