feat: Amount type that allows separating numbers with _s
#1758
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When entering amounts users will want to use `_`s to better read what they are typing. Also with this approach we could add more complex parsing for example `1 XLM`.
Ifropc
approved these changes
Nov 27, 2024
willemneal
force-pushed
the
feat/builder_amount
branch
from
e63b6c4
to
1d4aa0e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
New type which parses strings that include
_as i64s.Why
When entering amounts users will want to use
_s to better read what they are typing. Also with this approach we could add more complex parsing for example1 XLM.Known limitations
Allows for any number of
_s as long as they don't start or end the string.We might want to be stricter. e.g. only allow them where a,would go e.g.10_000_000