Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

keys: add command can warn on poor key practices #1806

Open
leighmcculloch opened this issue Dec 19, 2024 · 0 comments
Open

keys: add command can warn on poor key practices #1806

leighmcculloch opened this issue Dec 19, 2024 · 0 comments
Assignees

Comments

@leighmcculloch
Copy link
Member

The stellar keys add command could play a role in user education by warning when encountering keys that were likely generated with poor entropy. This is usually not something that can be detected with keys, except seed phrases of a length shorter than 24 words.

I suggest we add a warning like this when entering a seed phrase that's 12 words long instead of 24:

$ stellar keys add me --seed-phrase
Type a 12 or 24 word seed phrase: 
word word word word word word word word word word word word
⚠️  Warning that 12 word seed phrases do not result in a key generated with sufficient entropy to be secure. It is safer to use a 24 word seed phrase where possible. To generate a new key, use the `stellar keys generate` command.

Depends on:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Backlog (Not Ready)
Development

Successfully merging a pull request may close this issue.

1 participant