Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make seq num an option on tx #1643

Open
leighmcculloch opened this issue Oct 2, 2024 · 1 comment · May be fixed by #1760
Open

Make seq num an option on tx #1643

leighmcculloch opened this issue Oct 2, 2024 · 1 comment · May be fixed by #1760
Assignees

Comments

@leighmcculloch
Copy link
Member

leighmcculloch commented Oct 2, 2024

We don't have to do this in this PR, but we should make sequence number an option, that if isn't set uses the nxt seq num lookup, otherwise uses the value passed in. A good follow up to add later.

Originally posted by @leighmcculloch in #1551 (comment)

cc @willemneal

@github-project-automation github-project-automation bot moved this to Backlog (Not Ready) in DevX Oct 2, 2024
@willemneal willemneal self-assigned this Oct 2, 2024
@janewang janewang moved this from Backlog (Not Ready) to Todo (Ready for Dev) in DevX Oct 29, 2024
@willemneal willemneal moved this from Todo (Ready for Dev) to In Progress in DevX Nov 5, 2024
@willemneal willemneal linked a pull request Nov 5, 2024 that will close this issue
@leighmcculloch
Copy link
Member Author

After playing with this new option, I think we should change the design.

The new option is not really usable where it is in a meaningful way without being coupled with --build-only. The reason being is that any use where the tx will be sent immediately really just needs to use the current sequence number plus one. The only need for setting a different sequence number occurs when building and later sending.

Since the option is only usable in that advanced build-only case, I think we should make this something they can do with the stellar tx ... commands. It will keep the options advertised smaller for each of the subcommands being changed here, and keeps the advanced functionality for tx modifications in the same place. Maybe as a way to simply change a sequence number stellar tx set seq, where those commands could grow to support others like stellar tx set source-account. Or maybe by using the stellar tx edit.

Originally posted by @leighmcculloch in #1702 (comment)

@sagpatil sagpatil linked a pull request Nov 26, 2024 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: In Progress
Development

Successfully merging a pull request may close this issue.

2 participants