feat: add x and y medians to plot #188
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
testing
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
There was a problem hiding this comment.
Congratulations on making your first pull request to Data Morph! Please familiarize yourself with the contributing guidelines, if you haven't already.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #188 +/- ##
=======================================
Coverage 98.47% 98.47%
=======================================
Files 43 43
Lines 1839 1841 +2
Branches 114 114
=======================================
+ Hits 1811 1813 +2
Misses 25 25
Partials 3 3
|
stefmolin
requested changes
Jul 13, 2024
| @@ -24,12 +25,14 @@ def get_values(df: pd.DataFrame) -> SummaryStatistics: | |||
| Returns | |||
| ------- | |||
| SummaryStatistics | |||
| Named tuple consisting of mean and standard deviations of x and y, | |||
| Named tuple consisting of mean, median and standard deviations of x and y, | |||
There was a problem hiding this comment.
I much prefer Oxford commas, so let's change this to this:
Suggested change
| Named tuple consisting of mean, median and standard deviations of x and y, | |
| Named tuple consisting of mean, median, and standard deviations of x and y, |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #181
Describe your changes
Compute the median values for x and for y using the
pd.Series.medianmethod.Added median to the
get_valuesdocstring.Checklist