Other platforms

[174n]

Why isn't this app available for other platforms (linux/windows)? It was made using electron, so it can be cross platform

[stefansl]

I know, but I don't want to install wine or a virtual box on my mac. A pull request would be nice :)

[jancborchardt]

@stefansl I’m using Ubuntu 17.10 and am happy to help building this app as it’s suuuper useful for me. :) (Thanks for supporting png and also svg!)

The npm run pack-linux runs and the app works nicely. How can I contribute the build – do I submit a zip of what’s in the folder Image Shrinker-linux-x64 somewhere?

[stefansl]

@jancborchardt nice! i never expected, that it will run without additional coding. i could add you as contributer, if u want. then you could add the file here:
https://github.com/stefansl/image-shrinker/releases

[jancborchardt]

@stefansl hehe, at least it does seem to work from initial testing. :) And sure, am happy to be added & to add the Linux releases.

[174n]

@jancborchardt oh, I didn't know it's so easy to compile, didn't read the readme xD

[jancborchardt]

@stefansl sorry for the delay! :) I’m looking into it again, but I discovered an issue while using it regarding the loss-amount of the compression: #42

[jancborchardt]

@stefansl built with latest master and uploaded the zipped build in the release, also adjusted the release title and content accordingly. :) https://github.com/stefansl/image-shrinker/releases/tag/v1.3.6

This is what’s generated, and showing that it’s working:

The terminal just shows that of course when you move the main executable it will not work. Is there a way we can achieve a packaged file? Will look into if it’s possible to build a .deb file somehow.

[jancborchardt]

There seems to be https://github.com/unindented/electron-installer-debian for just that, and a guide at https://www.christianengvall.se/electron-packager-tutorial/ – will try that out the coming days.

[stefansl]

@jancborchardt Thank you very much! Nice work! I guess we just have to adjust the package.json in the section "build" and we need some new top-level-sections, eg. "deb", "rpm", "appImage"
We can use electron-builder, then. See the doku here: https://www.electron.build/configuration/linux

checkout https://www.electron.build/cli as well. or try electron-builder --help

you can see, how I'm building it in the package.json here:

image-shrinker/package.json

Line 31 in 176b7b6

"dist": "electron-builder --publish always"

maybe I've to adjust it to build-mac: "electron-builder --publish always --mac"

[JadedBlueEyes]

i'd rather like it for windows, so i'm gonna build it for myself. do you want a copy to put in releases? 😉

[JadedBlueEyes]

my build has been successful using npm install&&electron-packager . Image-Shrinker --asar=true --platform=win32 --arch=ia32 --ignore=/^release/i --overwrite! 🎉

unfortunately using electron-packager . 'Image Shrinker' means that the created executable is called 'image, strangely.

also, setting the icon with --icon=assets/icons/png/512x512.png or --icon=assets/icons/png/512x512 means it fails with the error

rcedit.exe failed with exit code 1. Cannot open icon file 'a'
Fatal error: Unable to set icon

[JadedBlueEyes]

with some changes, I've managed to fix the icon issue and remove the (ugly) top menu.

new build line is npm install&&electron-packager . Image-Shrinker --asar=true --platform=win32 --arch=ia32 --ignore=/^release/i --overwrite --icon=assets\icons\ico\[email protected].

the mac menu should stay, not sure about Linux. that can be changed with line 23 of mainmenu.js

should i launch a PR with my changes?

[JadedBlueEyes]

i'm also wondering about using electron-installer-windows to create a installer?

[stefansl]

@derpmarine168 yes, please! another good option is to use electron-builder https://www.electron.build/

[JadedBlueEyes]

working on it.

[JadedBlueEyes]

if my internet goes above 20KiB/s. 😉

[JadedBlueEyes]

sorry it's been taking so long. I've had to leave to do some other stuff, and now i'm done my git's died.

>git clone https://github.com/stefansl/image-shrinker.git
Cloning into 'image-shrinker'...
fatal: unable to access 'https://github.com/stefansl/image-shrinker.git/': error setting certificate verify 
locations:
  CAfile: /etc/pki/tls/certs/ca-bundle.crt
  CApath: none

even using http:// is no different.

[jancborchardt]

@derpmarine168 maybe this helps? :) https://stackoverflow.com/questions/3778042/github-error-cloning-my-private-repository

[JadedBlueEyes]

i have got the pull request: #44

also, @jancborchardt that article didn't work. none of those files even exist on my pc!

i'd rather not add the installer directly to the git repo, but i can upload it to releases if you add me as a Collaborator.

[despecial]

@JoelEllis did you release the window version anywhere? Thanks for the effort!

[JadedBlueEyes]

@despecial I did release a build on my fork, but it is now 52 commits behind, however I think you can build it yourself from master now.

[despecial]

@JoelEllis thanks, I dont have a windows machine - not sure if I can build it on a mac?!
It's for my friends, they use MS.

[stefansl]

@despecial I think you have to use a virtual
Machine with Windows installed. That’s why I don’t build the Win version

[stefansl]

With electron-builder it's possible to create versions for all platforms easily. I have to test this and I'm planing to remove electron-packer, because it's deprecated.

[stefansl]

see #56